opts: implement PlatformSlice option#6166
Draft
thaJeztah wants to merge 2 commits intodocker:masterfrom
Draft
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (25.80%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6166 +/- ##
==========================================
- Coverage 54.82% 54.79% -0.04%
==========================================
Files 364 365 +1
Lines 30467 30483 +16
==========================================
- Hits 16703 16702 -1
- Misses 12789 12807 +18
+ Partials 975 974 -1 🚀 New features to boost your workflow:
|
thaJeztah
force-pushed
the
platforms_option
branch
from
bd8a2c9 to
afb5683
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
platforms_option
branch
from
afb5683 to
02141af
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
platforms_option
branch
from
02141af to
7c8160f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had these changes in a local branch, but it wasn't finished yet; TODO;
optspackage, or better to have it in a separate package (due to extra dependencies involved)String()format be symmetrical with the input value (no space between values?)- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)